Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38354 )
Change subject: asus/p2b-ls: Replicate OEM GPO configuration
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38354/7/src/mainboard/asus/p2b-ls/d...
File src/mainboard/asus/p2b-ls/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38354/7/src/mainboard/asus/p2b-ls/d...
PS7, Line 13: lid_polarity
Maybe call it "case_open_polarity" instead?
This seems to have been dropped, so I guess this can be resolved?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38354
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86183acd8e1a830d7639c21ec179fbdbe937f8ee
Gerrit-Change-Number: 38354
Gerrit-PatchSet: 13
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Thu, 23 Apr 2020 20:27:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment