Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39502 )
Change subject: mb/google/deltaur: add deltaur mainboard initial support ......................................................................
Patch Set 8:
(4 comments)
Patch Set 7:
(12 comments)
Sorry to be a pain with the SPDX headers, but we'll get used to it 😊
Note that the Copyright lines were dropped recently, for example CB:39607
https://review.coreboot.org/c/coreboot/+/39502/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39502/8//COMMIT_MSG@7 PS8, Line 7: add deltaur mainboard initial support nit: maybe mention this is a Tiger Lake board?
(it says so in Kconfig)
https://review.coreboot.org/c/coreboot/+/39502/8/src/mainboard/google/deltau... File src/mainboard/google/deltaur/bootblock.c:
https://review.coreboot.org/c/coreboot/+/39502/8/src/mainboard/google/deltau... PS8, Line 4: Copyright 2020 The coreboot project Authors. Copyright lines were removed, see CB:39607 for the rationale. Please use:
/* SPDX-License-Identifier: GPL-2.0-or-later */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/39502/8/src/mainboard/google/deltau... File src/mainboard/google/deltaur/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/39502/8/src/mainboard/google/deltau... PS8, Line 27: /* CPU */ I don't think this comment is very useful. Could we remove it, please?
https://review.coreboot.org/c/coreboot/+/39502/8/src/mainboard/google/deltau... File src/mainboard/google/deltaur/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39502/8/src/mainboard/google/deltau... PS8, Line 32: override_pads, override_num); Should fit in 96 chars