build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46587 )
Change subject: lenovo/g505s: proper way of IRQ table programming ......................................................................
Patch Set 1:
(257 comments)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... File src/mainboard/lenovo/g505s/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 21: /* bus, dev | fn, {link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap}, slot, rfu */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: {0x00, (0x01 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: {0x00, (0x01 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 23: {0x00, (0x02 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x03, 0x9cb8}, {0x04, 0x9cb8}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 23: {0x00, (0x02 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x03, 0x9cb8}, {0x04, 0x9cb8}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: {0x00, (0x10 << 3) | 0x0, {{0x03, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: {0x00, (0x10 << 3) | 0x0, {{0x03, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 25: {0x00, (0x11 << 3) | 0x0, {{0x04, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 25: {0x00, (0x11 << 3) | 0x0, {{0x04, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 26: {0x00, (0x12 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 26: {0x00, (0x12 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 27: {0x00, (0x13 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 27: {0x00, (0x13 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 28: {0x00, (0x14 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x03, 0x9cb8}, {0x04, 0x9cb8}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 28: {0x00, (0x14 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x03, 0x9cb8}, {0x04, 0x9cb8}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 29: {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 29: {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 30: {0x01, (0x00 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x03, 0x9cb8}, {0x04, 0x9cb8}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 30: {0x01, (0x00 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x03, 0x9cb8}, {0x04, 0x9cb8}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 31: {0x02, (0x00 << 3) | 0x0, {{0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 31: {0x02, (0x00 << 3) | 0x0, {{0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... File src/mainboard/lenovo/g505s/mainboard.c:
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x00] = 0x03,0x04,0x05,0x07,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x00] = 0x03,0x04,0x05,0x07,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x00] = 0x03,0x04,0x05,0x07,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x00] = 0x03,0x04,0x05,0x07,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x00] = 0x03,0x04,0x05,0x07,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x00] = 0x03,0x04,0x05,0x07,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x00] = 0x03,0x04,0x05,0x07,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 20: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 20: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 20: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 20: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 20: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 20: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 20: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 26: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 26: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 26: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 26: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 26: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 26: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 26: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 33: [0x00] = 0x10,0x11,0x12,0x13,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 33: [0x00] = 0x10,0x11,0x12,0x13,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 33: [0x00] = 0x10,0x11,0x12,0x13,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 33: [0x00] = 0x10,0x11,0x12,0x13,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 33: [0x00] = 0x10,0x11,0x12,0x13,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 33: [0x00] = 0x10,0x11,0x12,0x13,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 33: [0x00] = 0x10,0x11,0x12,0x13,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 35: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 35: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 35: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 35: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 35: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 35: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 35: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 37: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 37: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 37: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 37: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 37: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 37: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 37: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 39: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 39: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 39: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 39: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 39: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 58: {GFX_DEVFN, {PIRQ_A, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* VGA: 01.0 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 58: {GFX_DEVFN, {PIRQ_A, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* VGA: 01.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 59: {ACTL_DEVFN,{PIRQ_NC, PIRQ_B, PIRQ_NC, PIRQ_NC}}, /* Audio: 01.1 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 59: {ACTL_DEVFN,{PIRQ_NC, PIRQ_B, PIRQ_NC, PIRQ_NC}}, /* Audio: 01.1 */ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 59: {ACTL_DEVFN,{PIRQ_NC, PIRQ_B, PIRQ_NC, PIRQ_NC}}, /* Audio: 01.1 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 60: {NB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* x4 PCIe: 02.1 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 61: {NB_PCIE_PORT5_DEVFN, {PIRQ_B, PIRQ_C, PIRQ_D, PIRQ_A}}, /* Edge: 02.5 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 62: {XHCI_DEVFN, {PIRQ_C, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* XHCI: 10.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 63: {SATA_DEVFN, {PIRQ_SATA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* SATA: 11.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 64: {OHCI1_DEVFN, {PIRQ_OHCI1, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI1: 12.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 65: {EHCI1_DEVFN, {PIRQ_NC, PIRQ_EHCI1, PIRQ_NC, PIRQ_NC}}, /* EHCI1: 12.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 66: {OHCI2_DEVFN, {PIRQ_OHCI2, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI2: 13.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 67: {EHCI2_DEVFN, {PIRQ_NC, PIRQ_EHCI2, PIRQ_NC, PIRQ_NC}}, /* EHCI2: 13.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 68: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 69: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 70: {HDA_DEVFN, {PIRQ_HDA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* HDA: 14.2 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 70: {HDA_DEVFN, {PIRQ_HDA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* HDA: 14.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... File src/mainboard/lenovo/g505s/mptable.c:
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 14: [0x00] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 14: [0x00] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 14: [0x00] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 14: [0x00] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 14: [0x00] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 14: [0x00] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 14: [0x00] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 16: [0x08] = 0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 16: [0x08] = 0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 16: [0x08] = 0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 16: [0x08] = 0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 16: [0x08] = 0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 16: [0x08] = 0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 16: [0x08] = 0x0A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x10] = 0x09,0x1F,0x1F,0x0B,0x1F,0x0B,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x10] = 0x09,0x1F,0x1F,0x0B,0x1F,0x0B,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x10] = 0x09,0x1F,0x1F,0x0B,0x1F,0x0B,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x10] = 0x09,0x1F,0x1F,0x0B,0x1F,0x0B,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x10] = 0x09,0x1F,0x1F,0x0B,0x1F,0x0B,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x10] = 0x09,0x1F,0x1F,0x0B,0x1F,0x0B,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 18: [0x10] = 0x09,0x1F,0x1F,0x0B,0x1F,0x0B,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 19: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 19: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 19: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 19: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 19: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 19: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 19: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 19: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 19: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 21: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 21: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 21: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 21: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 21: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 21: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 21: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 22: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: [0x30] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: [0x30] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: [0x30] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: [0x30] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: [0x30] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: [0x30] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 24: [0x30] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 25: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 25: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 25: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 25: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 25: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 25: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 25: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 27: [0x40] = 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 27: [0x40] = 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 27: [0x40] = 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 27: [0x40] = 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 27: [0x40] = 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 27: [0x40] = 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 27: [0x40] = 0x1F,0x1F,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 28: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 28: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 28: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 28: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 28: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 28: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 28: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 29: [0x50] = 0x1F,0x1F,0x1F,0x1F space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 29: [0x50] = 0x1F,0x1F,0x1F,0x1F space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 29: [0x50] = 0x1F,0x1F,0x1F,0x1F space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 34: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 34: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 34: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 34: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 34: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 34: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 34: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 36: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 36: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 36: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 36: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 36: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 36: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 36: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 38: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 38: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 38: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 38: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 38: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 38: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 38: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x10,0x1F,0x10, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 39: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 39: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 39: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 39: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 39: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 39: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 39: [0x18] = 0x1F,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x20] = 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x20] = 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x20] = 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x20] = 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x20] = 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x20] = 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 41: [0x20] = 0x05,0x1F,0x1F,0x1F,0x1F,0x1F,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 42: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 42: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 42: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 42: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 42: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 42: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 42: [0x28] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 44: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 44: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 44: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 44: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 44: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 44: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 44: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 45: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 45: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 45: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 45: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 45: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 45: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 45: [0x38] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 47: [0x40] = 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 47: [0x40] = 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 47: [0x40] = 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 47: [0x40] = 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 47: [0x40] = 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 47: [0x40] = 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 47: [0x40] = 0x11,0x13,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 48: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 48: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 48: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 48: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 48: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 48: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 48: [0x48] = 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 49: [0x50] = 0x10,0x11,0x12,0x13 space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 49: [0x50] = 0x10,0x11,0x12,0x13 space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 49: [0x50] = 0x10,0x11,0x12,0x13 space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 115: for (byte = 0x0; byte < sizeof(picr_data_ptr); byte ++) { space prohibited before that '++' (ctx:WxB)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 121: for (byte = 0x0; byte < sizeof(intr_data_ptr); byte ++) { space prohibited before that '++' (ctx:WxB)
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 137: smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, (bus), (((dev)<<2)|(fn)), ioapic_id, (pin)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 206: #define IO_LOCAL_INT(type, intr, apicid, pin) \ macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/46587/1/src/mainboard/lenovo/g505s/... PS1, Line 207: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)); line over 96 characters