Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39133 )
Change subject: mb/kontron: Add Kontron mAL10 COMe module support ......................................................................
Patch Set 56:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39133/48/src/mainboard/kontron/mal1... File src/mainboard/kontron/mal10/romstage.c:
https://review.coreboot.org/c/coreboot/+/39133/48/src/mainboard/kontron/mal1... PS48, Line 10: Profile
Is there an enum for this?
Outside the scope of this patch This will be done in the next patches
https://review.coreboot.org/c/coreboot/+/39133/48/src/mainboard/kontron/mal1... PS48, Line 13: DualRankSupportEnable
Why disable support for dual rank?
This is needed if the memory exceeds 16GB per channel. In the case of mal10, the memory capacity is limited to 8GB.
https://review.coreboot.org/c/coreboot/+/39133/48/src/mainboard/kontron/mal1... PS48, Line 19: RmtCheckRun
Why skip margin check?
Enable TEST=successful boot
https://review.coreboot.org/c/coreboot/+/39133/48/src/mainboard/kontron/mal1... PS48, Line 25: MrcFastBoot
Why no fast boot?
Enable TEST=successful boot
https://review.coreboot.org/c/coreboot/+/39133/48/src/mainboard/kontron/mal1... File src/mainboard/kontron/mal10/variants/mal10/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39133/48/src/mainboard/kontron/mal1... PS48, Line 96: 1
Problems with HS400?
Only on our RTOS, there are no problems with Ubuntu. Let's set this to HS400