build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48426 )
Change subject: asus/a88xm-e: add the PIRQ routing table ......................................................................
Patch Set 4:
(22 comments)
File src/mainboard/asus/a88xm-e/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/48426/comment/3d106fe6_610084cc PS4, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/1dc5f5f0_7dcab900 PS4, Line 24: {0x00, (0x00 << 3) | 0x2, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/a4fc30f6_643402d1 PS4, Line 27: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/1a9af58f_a637530a PS4, Line 29: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/85d1a7b1_78e27393 PS4, Line 31: {0x00, (0x04 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/0c7a8bd7_4696cd8c PS4, Line 33: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/c369e6a4_cbd2dc31 PS4, Line 35: {0x00, (0x06 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/1d1b55f3_419654f2 PS4, Line 37: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/3a11a039_a0dcd8f0 PS4, Line 39: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/e3297026_6b20f21d PS4, Line 42: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/20a240a1_850d2c09 PS4, Line 45: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/34c3533e_9c24a98c PS4, Line 48: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccf0}, {0x02, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/ce4b04cb_a33decf8 PS4, Line 51: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/5a3f8d7c_a2c982c6 PS4, Line 53: {0x00, (0x14 << 3) | 0x4, {{0x05, 0xccf0}, {0x06, 0xccf0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/21d6fba0_54e81743 PS4, Line 55: {0x00, (0x15 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/f65fa026_307e5bec PS4, Line 57: {0x00, (0x15 << 3) | 0x1, {{0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/236815e0_d5586f41 PS4, Line 59: {0x00, (0x15 << 3) | 0x2, {{0x04, 0xccf0}, {0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/4bdd5371_f35816d1 PS4, Line 61: {0x00, (0x15 << 3) | 0x3, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/56c3a8e4_73bb6588 PS4, Line 63: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x1, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/ee664ed6_1f71c91c PS4, Line 65: {0x02, (0x00 << 3) | 0x0, {{0x01, 0xccf0}, {0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0} }, 0x2, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/58eccfde_412de17d PS4, Line 67: {0x03, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x3, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48426/comment/f650362a_85d68f18 PS4, Line 69: {0x04, (0x00 << 3) | 0x0, {{0x02, 0xccf0}, {0x03, 0xccf0}, {0x04, 0xccf0}, {0x01, 0xccf0} }, 0x4, 0x0} line over 96 characters