Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36767 )
Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................
Patch Set 7: Code-Review+2
(2 comments)
Sorry, vacation
https://review.coreboot.org/c/coreboot/+/36767/7/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/panel_anx7625.c:
https://review.coreboot.org/c/coreboot/+/36767/7/src/mainboard/google/kukui/...
PS7, Line 65: anx7625_init(i2c_bus);
nit: handle errors?
https://review.coreboot.org/c/coreboot/+/36767/7/src/mainboard/google/kukui/...
PS7, Line 71: anx7625_dp_start(i2c_bus, edid);
here too
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36767
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7dc9c68d076fd0ba4e963cde9414d25c17b332cb
Gerrit-Change-Number: 36767
Gerrit-PatchSet: 7
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Jan 2020 21:57:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment