Change in coreboot[master]: mb/google/kukui: Support panels using ANX7625

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36767 )

Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................

mb/google/kukui: Support panels using ANX7625

For Kukui followers using ANX7625 eDP bridge to access panel.

BUG=b:140132295
TEST=make # board = kukui

Change-Id: I7dc9c68d076fd0ba4e963cde9414d25c17b332cb
Signed-off-by: Hung-Te Lin 
---
M src/mainboard/google/kukui/Kconfig
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_anx7625.c
3 files changed, 76 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/36767/1

diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig
index e6d604e..3b53478 100644
--- a/src/mainboard/google/kukui/Kconfig
+++ b/src/mainboard/google/kukui/Kconfig
@@ -42,6 +42,7 @@
    select MAINBOARD_FORCE_NATIVE_VGA_INIT
    select HAVE_LINEAR_FRAMEBUFFER
    select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_JACUZZI
+	select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_DAMU || BOARD_GOOGLE_KAPPA
    select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE

config MAINBOARD_DIR
diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc
index 2e8a79a..7839422 100644
--- a/src/mainboard/google/kukui/Makefile.inc
+++ b/src/mainboard/google/kukui/Makefile.inc
@@ -30,4 +30,6 @@
 ramstage-$(CONFIG_BOARD_GOOGLE_KRANE) += panel_krane.c
 ramstage-$(CONFIG_BOARD_GOOGLE_KUKUI) += panel_kukui.c
 ramstage-$(CONFIG_DRIVER_PARADE_PS8640) += panel_ps8640.c
+ramstage-$(CONFIG_DRIVER_ANALOGIX_ANX7625) += panel_anx7625.c
+
 ramstage-y += reset.c
diff --git a/src/mainboard/google/kukui/panel_anx7625.c b/src/mainboard/google/kukui/panel_anx7625.c
new file mode 100644
index 0000000..10cbf5c
--- /dev/null
+++ b/src/mainboard/google/kukui/panel_anx7625.c
@@ -0,0 +1,73 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2019 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <console/console.h>
+#include <delay.h>
+#include <drivers/analogix/anx7625/anx7625.h>
+#include <edid.h>
+#include <gpio.h>
+#include <soc/i2c.h>
+#include <string.h>
+
+#include "panel.h"
+
+
+static void power_on_anx7625(void)
+{
+	gpio_output(GPIO_MIPIBRDG_RST_L_1V8, 0);
+	gpio_output(GPIO_PP1200_MIPIBRDG_EN, 1);    //1.0
+	gpio_output(GPIO_VDDIO_MIPIBRDG_EN, 1);    //3.3
+	gpio_output(GPIO_PP1800_LCM_EN, 1);    //1.8
+	mdelay(2);
+	gpio_output(GPIO_MIPIBRDG_PWRDN_L_1V8, 1);
+	mdelay(10);
+	gpio_output(GPIO_MIPIBRDG_RST_L_1V8, 1);
+	gpio_output(GPIO_PP3300_LCM_EN, 1);
+}
+
+static void dummy_power_on(void)
+{
+	/* The panel has been already powered on when getting panel information
+	 * so we should do nothing here.
+	 */
+}
+
+static struct panel_serializable_data anx7625_data = {
+	.orientation = LB_FB_ORIENTATION_NORMAL,
+	.init = { INIT_END_CMD },
+};
+
+static struct panel_description anx7625_panel = {
+	.s = &anx7625_data,
+	.power_on = dummy_power_on,
+};
+
+struct panel_description *get_panel_description(int panel_id)
+{
+	/* To read panel EDID, we have to first power on anx7625. */
+	power_on_anx7625();
+
+	u8 i2c_bus = 4;
+	mtk_i2c_bus_init(i2c_bus);
+
+	anx7625_init(i2c_bus);
+	struct edid *edid = &anx7625_data.edid;
+	if (anx7625_dp_get_edid(i2c_bus, edid)) {
+		printk(BIOS_ERR, "Can't get panel's edid\n");
+		return NULL;
+	}
+	anx7625_dp_start(i2c_bus, edid);
+	return &anx7625_panel;
+}

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36767 )

Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................

Patch Set 3: Code-Review+1

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has uploaded a new patch set (#5) to the change originally created by Hung-Te Lin. ( https://review.coreboot.org/c/coreboot/+/36767 )

Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................

mb/google/kukui: Support panels using ANX7625

For Kukui followers using ANX7625 eDP bridge to access panel.

BUG=b:140132295
TEST=make # board = kukui

Change-Id: I7dc9c68d076fd0ba4e963cde9414d25c17b332cb
Signed-off-by: Hung-Te Lin 
---
M src/mainboard/google/kukui/Kconfig
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_anx7625.c
3 files changed, 76 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/36767/5

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36767 )

Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................

Patch Set 7:

ping - any issues left on this change?

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36767 )

Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................

Patch Set 7:

+Julius - need some review here.

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36767 )

Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................

Patch Set 7:

ping?

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36767 )

Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................

Patch Set 7: Code-Review+2

(2 comments)

Sorry, vacation

https://review.coreboot.org/c/coreboot/+/36767/7/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/panel_anx7625.c:

https://review.coreboot.org/c/coreboot/+/36767/7/src/mainboard/google/kukui/... 
PS7, Line 65: 	anx7625_init(i2c_bus);
nit: handle errors?

https://review.coreboot.org/c/coreboot/+/36767/7/src/mainboard/google/kukui/... 
PS7, Line 71: 	anx7625_dp_start(i2c_bus, edid);
here too

[Hung-Te Lin (Code Review)]

Hello Yu-Ping Wu, Julius Werner, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36767

to look at the new patch set (#8).

Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................

mb/google/kukui: Support panels using ANX7625

For Kukui followers using ANX7625 eDP bridge to access panel.

BUG=b:140132295
TEST=make # board = kukui

Change-Id: I7dc9c68d076fd0ba4e963cde9414d25c17b332cb
Signed-off-by: Hung-Te Lin 
---
M src/mainboard/google/kukui/Kconfig
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_anx7625.c
3 files changed, 82 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/36767/8

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36767 )

Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36767/7/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/panel_anx7625.c:

https://review.coreboot.org/c/coreboot/+/36767/7/src/mainboard/google/kukui/... 
PS7, Line 65: 	anx7625_init(i2c_bus);
> nit: handle errors?

Done

https://review.coreboot.org/c/coreboot/+/36767/7/src/mainboard/google/kukui/... 
PS7, Line 71: 	anx7625_dp_start(i2c_bus, edid);
> here too

Done

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36767 )

Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................

Patch Set 8:

ping?

self +2 since jwerner@ gave +2 and simply fixing nits.

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36767 )

Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................

Patch Set 8: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36767 )

Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................

Patch Set 8: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36767 )

Change subject: mb/google/kukui: Support panels using ANX7625
......................................................................

mb/google/kukui: Support panels using ANX7625

For Kukui followers using ANX7625 eDP bridge to access panel.

BUG=b:140132295
TEST=make # board = kukui

Change-Id: I7dc9c68d076fd0ba4e963cde9414d25c17b332cb
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36767
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Georgi 
---
M src/mainboard/google/kukui/Kconfig
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_anx7625.c
3 files changed, 82 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Hung-Te Lin: Looks good to me, approved

diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig
index 098ce49..6236ea9 100644
--- a/src/mainboard/google/kukui/Kconfig
+++ b/src/mainboard/google/kukui/Kconfig
@@ -42,6 +42,7 @@
    select MAINBOARD_FORCE_NATIVE_VGA_INIT
    select HAVE_LINEAR_FRAMEBUFFER
    select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_JACUZZI
+	select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_DAMU || BOARD_GOOGLE_KAPPA
    select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE

config MAINBOARD_DIR
diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc
index 2e8a79a..7839422 100644
--- a/src/mainboard/google/kukui/Makefile.inc
+++ b/src/mainboard/google/kukui/Makefile.inc
@@ -30,4 +30,6 @@
 ramstage-$(CONFIG_BOARD_GOOGLE_KRANE) += panel_krane.c
 ramstage-$(CONFIG_BOARD_GOOGLE_KUKUI) += panel_kukui.c
 ramstage-$(CONFIG_DRIVER_PARADE_PS8640) += panel_ps8640.c
+ramstage-$(CONFIG_DRIVER_ANALOGIX_ANX7625) += panel_anx7625.c
+
 ramstage-y += reset.c
diff --git a/src/mainboard/google/kukui/panel_anx7625.c b/src/mainboard/google/kukui/panel_anx7625.c
new file mode 100644
index 0000000..b6a57e4
--- /dev/null
+++ b/src/mainboard/google/kukui/panel_anx7625.c
@@ -0,0 +1,79 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2019 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <console/console.h>
+#include <delay.h>
+#include <drivers/analogix/anx7625/anx7625.h>
+#include <edid.h>
+#include <gpio.h>
+#include <soc/i2c.h>
+#include <string.h>
+
+#include "panel.h"
+
+
+static void power_on_anx7625(void)
+{
+	gpio_output(GPIO_MIPIBRDG_RST_L_1V8, 0);
+	gpio_output(GPIO_PP1200_MIPIBRDG_EN, 1);
+	gpio_output(GPIO_VDDIO_MIPIBRDG_EN, 1);
+	gpio_output(GPIO_PP1800_LCM_EN, 1);
+	mdelay(2);
+	gpio_output(GPIO_MIPIBRDG_PWRDN_L_1V8, 1);
+	mdelay(10);
+	gpio_output(GPIO_MIPIBRDG_RST_L_1V8, 1);
+	gpio_output(GPIO_PP3300_LCM_EN, 1);
+}
+
+static void dummy_power_on(void)
+{
+	/* The panel has been already powered on when getting panel information
+	 * so we should do nothing here.
+	 */
+}
+
+static struct panel_serializable_data anx7625_data = {
+	.orientation = LB_FB_ORIENTATION_NORMAL,
+	.init = { INIT_END_CMD },
+};
+
+static struct panel_description anx7625_panel = {
+	.s = &anx7625_data,
+	.power_on = dummy_power_on,
+};
+
+struct panel_description *get_panel_description(int panel_id)
+{
+	/* To read panel EDID, we have to first power on anx7625. */
+	power_on_anx7625();
+
+	u8 i2c_bus = 4;
+	mtk_i2c_bus_init(i2c_bus);
+
+	if (anx7625_init(i2c_bus)) {
+		printk(BIOS_ERR, "Can't init ANX7625 bridge.\n");
+		return NULL;
+	}
+	struct edid *edid = &anx7625_data.edid;
+	if (anx7625_dp_get_edid(i2c_bus, edid)) {
+		printk(BIOS_ERR, "Can't get panel's edid.\n");
+		return NULL;
+	}
+	if (anx7625_dp_start(i2c_bus, edid) < 0) {
+		printk(BIOS_ERR, "Can't start display via ANX7625.\n");
+		return NULL;
+	}
+	return &anx7625_panel;
+}