Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47189 )
Change subject: mb/purism_librem_mini: Add child device, slot descriptions to PCIe RPs
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47189/1/src/mainboard/purism/librem...
File src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47189/1/src/mainboard/purism/librem...
PS1, Line 218: device pci 00.0 on end # x1 (LAN)
why just this one? I'm adding to all 3 (enabled) RPs
erm. it was late... actually the slot descriptions could be a separate one, but it's not that important I guess. let's see what others say :-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id306100fc691dcbde48b65092d0be9d7e73c0722
Gerrit-Change-Number: 47189
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Nov 2020 09:29:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment