build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49214 )
Change subject: util/sconfig: Emit chip config pointers for PCI devices on root bus
......................................................................
Patch Set 6:
(3 comments)
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/49214/comment/ea37890f_66a0197c
PS6, Line 1228: fprintf(head, "extern DEVTREE_CONST void *const __pci_0_%02x_%d_config;\n",
line over 96 characters
https://review.coreboot.org/c/coreboot/+/49214/comment/b06c5ea1_1130ea3e
PS6, Line 1230: fprintf(fil, "DEVTREE_CONST void *const __pci_0_%02x_%d_config = &%s_info_%d;\n",
line over 96 characters
https://review.coreboot.org/c/coreboot/+/49214/comment/7eea776e_6c8aa747
PS6, Line 1231: ptr->path_a, ptr->path_b, chip_ins->chip->name_underscore, chip_ins->id);
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49214
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d42e926dbfae14b889ade6dda363d8607974cae
Gerrit-Change-Number: 49214
Gerrit-PatchSet: 6
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 08 Jan 2021 19:50:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment