Attention is currently required from: Raul Rangel, Subrata Banik, Kane Chen, Tim Wawrzynczak, Arthur Heymans, Eric Lai.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70799 )
Change subject: Revert "cpu/x86/mtrr: Print cpu index number when set up MTRRs for BSP/APs"
......................................................................
Patch Set 2: Verified-1
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-166183):
https://review.coreboot.org/c/coreboot/+/70799/comment/3dd6b40b_a8f8a6bb
PS2, Line 11: Reason for revert: Calling cpu_index before the cpu_info segment has been setup. Maybe rewrite this CL to print the APIC IDs insead of the cpu_index?
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I525ccffc67c7c798afd318b14e263f86fec7b001
Gerrit-Change-Number: 70799
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 14 Dec 2022 21:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment