Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: src/mainboard/asus: Add H110M-E/M.2 mainboard support ......................................................................
Patch Set 18:
(2 comments)
Patch Set 18: (5 comments) I'm sorry for the waiting. I urgently needed to finish the project at work.
No worries, there's no time pressure with this port. Any input is appreciated :D
as he ported asrock/h110m
This work isn't completed yet. Now I'm working on gpio, and after that I need to solve problems with superio.
Good luck :)
and probably knows Skylake stuff better than I do
I'm not sure about that :)
I don't have any Skylake hardware to look at :S
https://review.coreboot.org/c/coreboot/+/34603/18/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/18/src/mainboard/asus/h110m-e... PS18, Line 278: device pci 14.2 on # Thermal Subsystem : subsystemid 0x1849 0xa131 : end
Are you sure about that? This device is always enabled on boards with AMI UEFI.
I checked the lspci with vendor BIOS for that board and it is reported as disabled. (does not appear)
https://review.coreboot.org/c/coreboot/+/34603/18/src/mainboard/asus/h110m-e... PS18, Line 285: device pci 16.0 on # Management Engine Interface 1 : subsystemid 0x1849 0xa131 : end
Probably me_cleaner was used to disable this device. However, we need to be very careful with ME: […]
Could be me_cleaner, yes.
While doing the porting, I would recommend using a working ME firmware. Weird issues may happen with a me_cleaned firmware, and troubleshooting them is nearly impossible.