Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33985 )
Change subject: include/cpu/x86: Add STM Support ......................................................................
Patch Set 17:
(2 comments)
Was this change reviewed?
https://review.coreboot.org/c/coreboot/+/33985/17/src/include/cpu/x86/msr.h File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/33985/17/src/include/cpu/x86/msr.h@... PS17, Line 36: (1<<0) Really? This escaped review? Also, note that defines for bits within a register are indented with an extra space.
https://review.coreboot.org/c/coreboot/+/33985/17/src/include/cpu/x86/smm.h File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/33985/17/src/include/cpu/x86/smm.h@... PS17, Line 69: u32 start32_offset;
We should keep the addition of fields with the rest of the patches that utilize them. […]
They might also be breaking Werner's APL boards because of the increased size.