Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38823 )
Change subject: mb/google/octopus: support new Elan touch panel for Foob
......................................................................
Patch Set 7:
(3 comments)
Should both screens be supported by the same build?
https://review.coreboot.org/c/coreboot/+/38823/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38823/7//COMMIT_MSG@8
PS7, Line 8: for Foob
In coreboot we use exactly one line for the commit message summary.
https://review.coreboot.org/c/coreboot/+/38823/7//COMMIT_MSG@10
PS7, Line 10: include
includes
https://review.coreboot.org/c/coreboot/+/38823/7//COMMIT_MSG@11
PS7, Line 11: touch panel and USI pen.
More words fit in 75 characters lines.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38823
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibec3d08cc740e398a10a5c845181318724afc70a
Gerrit-Change-Number: 38823
Gerrit-PatchSet: 7
Gerrit-Owner: Tommie Lin
tong.lin@bitland.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Tommie Lin
tong.lin@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 27 Feb 2020 13:04:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment