13 Oct
2020
13 Oct
'20
10:34 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45637 )
Change subject: mb/clevo/cml-u: Remove duplicate Kconfig type definitions ......................................................................
Patch Set 3:
That's a lot of options. If any of them isn't declared with the type globally, you rely on the type set by another board (I guess, but who really knows). Please check if they all have a declaration already.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45637
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39e5b27abdb17c1d72e316b92f7ee4c5cc1f5d97
Gerrit-Change-Number: 45637
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Tue, 13 Oct 2020 20:34:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment