[coreboot-gerrit] Change in coreboot[master]: nb/amd/pi/00730F01: enable ACS and AER for PCIe ports

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35313 )

Change subject: nb/amd/pi/00730F01: enable ACS and AER for PCIe ports
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35313/7/src/northbridge/amd/pi/0073... 
File src/northbridge/amd/pi/00730F01/northbridge.c:

https://review.coreboot.org/c/coreboot/+/35313/7/src/northbridge/amd/pi/0073... 
PS7, Line 784: result
> results

ACS is Access Control Services, which is plural. Shouldn't it stay `result`?

https://review.coreboot.org/c/coreboot/+/35313/7/src/northbridge/amd/pi/0073... 
PS7, Line 794: 	value |= (BIT(5) | BIT(6));
> If you add macros for these to, you could remove the comment here. […]

AMD BKDG doesn't describe these bits, so I don't know which one is which. This is a 50/50 gamble.