View Change

2 comments:

• File src/northbridge/amd/pi/00730F01/northbridge.c:

  • Patch Set #7, Line 784: result

    results

    ACS is Access Control Services, which is plural. Shouldn't it stay `result`?

  • Patch Set #7, Line 794: value |= (BIT(5) | BIT(6));

    If you add macros for these to, you could remove the comment here. […]

    AMD BKDG doesn't describe these bits, so I don't know which one is which. This is a 50/50 gamble.

To view, visit change 35313. To unsubscribe, or for help writing mail filters, visit settings.