28 Jan
2019
28 Jan
'19
3:20 a.m.
Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31118 )
Change subject: google/kukui: Implement HW reset function ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31118/2/src/mainboard/google/kukui/Makefile.... File src/mainboard/google/kukui/Makefile.inc:
https://review.coreboot.org/#/c/31118/2/src/mainboard/google/kukui/Makefile.... PS2, Line 7: bootblock-y += reset.c
this implies we're adding back gpio stack to bootblock... […]
Seems we don't need do_board_reset() in bootblock at this moment. IS it OK that we just remove this line?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31118
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9afad84af2031a766bc08fc76c8b5f55588c453a
Gerrit-Change-Number: 31118
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Hsieh tristan.shieh@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 28 Jan 2019 11:20:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment