[coreboot-gerrit] Change in coreboot[master]: cpu/x86/lapic: Support x86_64 and clean up code

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36777 )

Change subject: cpu/x86/lapic: Support x86_64 and clean up code
......................................................................

Patch Set 6:

(3 comments)

https://review.coreboot.org/c/coreboot/+/36777/6/src/include/cpu/x86/lapic.h 
File src/include/cpu/x86/lapic.h:

https://review.coreboot.org/c/coreboot/+/36777/6/src/include/cpu/x86/lapic.h... 
PS6, Line 10: 	return *((volatile uint32_t *)(LAPIC_DEFAULT_BASE+reg));
could add spaces around +, while we touch the line anyway

https://review.coreboot.org/c/coreboot/+/36777/6/src/include/cpu/x86/lapic.h... 
PS6, Line 42: uint32_t
Why 32? if it's not 32 exactly, why not use `unsigned int`?

https://review.coreboot.org/c/coreboot/+/36777/6/src/include/cpu/x86/lapic.h... 
PS6, Line 60: volatile
why volatile?