Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40721 )
Change subject: nb/intel/sandybridge/raminit: Fix ECC scrub ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/c/coreboot/+/40721/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/40721/8/src/northbridge/intel/sandy... PS8, Line 4311: .inc_addr_1 = 1,
Do we need any increments with a single iteration?
without .inc_addr_1 = 1 it doesn't work.
https://review.coreboot.org/c/coreboot/+/40721/8/src/northbridge/intel/sandy... PS8, Line 4312: .inc_addr_8 = 0,
Fields that are zero on this register can be dropped. […]
Done
https://review.coreboot.org/c/coreboot/+/40721/8/src/northbridge/intel/sandy... PS8, Line 4335: ctrl->tWTR + : ctrl->CWL + 8,
nit: add two spaces to align `ctrl->` on both lines
Done
https://review.coreboot.org/c/coreboot/+/40721/8/src/northbridge/intel/sandy... PS8, Line 4348: .inc_bank = 0,
Fields that are zero on this register can be dropped. […]
Done
https://review.coreboot.org/c/coreboot/+/40721/8/src/northbridge/intel/sandy... PS8, Line 4381: .inc_bank = 0,
Fields that are zero on this register can be dropped. […]
Done