Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42097 )
Change subject: mb/pcengines/apu2/mptable.c: fix invalid MP table and IRQ table ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42097/2/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/42097/2/src/mainboard/pcengines/apu... PS2, Line 95: {GFX_DEVFN, {PIRQ_A, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* VGA: 01.0 */ : {ACTL_DEVFN,{PIRQ_NC, PIRQ_B, PIRQ_NC, PIRQ_NC}}, /* Audio: 01.1 */ We do not have the VGA and Audio. GX-412TC lacks the graphics and its audio device as well
https://review.coreboot.org/c/coreboot/+/42097/2/src/mainboard/pcengines/apu... PS2, Line 101: {NB_PCIE_PORT5_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* mPCIe slot 1: 02.5 */
trailing whitespace
This whitespace should be removed
https://review.coreboot.org/c/coreboot/+/42097/2/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/mptable.c:
https://review.coreboot.org/c/coreboot/+/42097/2/src/mainboard/pcengines/apu... PS2, Line 90: /* GPP0 */ : PCI_INT(0x0, 0x2, 0x0, 0x10); // Network 3 : /* GPP1 */ : PCI_INT(0x0, 0x2, 0x1, 0x11); // Network 2 : /* GPP2 */ : PCI_INT(0x0, 0x2, 0x2, 0x12); // Network 1 : /* GPP3 */ : PCI_INT(0x0, 0x2, 0x3, 0x13); // mPCI : /* GPP4 */ : PCI_INT(0x0, 0x2, 0x0, 0x10); // mPCI Aren't the PCIe bridges BDF from 2.1 to 2.5?
https://review.coreboot.org/c/coreboot/+/42097/2/src/mainboard/pcengines/apu... PS2, Line 99: PCI_INT(0x0, 0x2, 0x0, 0x10); // mPCI What is the reason of change here?