Attention is currently required from: Marc Jones, Simon Chou, Jonathan Zhang, TimLiu-SMCI, Johnny Lin, Paul Menzel, Christian Walter, Angel Pons, Arthur Heymans, Shuming Chu (Shuming), Shelly Chang, Elyes Haouas.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71967 )
Change subject: soc/intel/xeon_sp/spr: Add ACPI support for Sapphire Rapids
......................................................................
Patch Set 25:
(1 comment)
File src/soc/intel/xeon_sp/spr/soc_acpi.c:
https://review.coreboot.org/c/coreboot/+/71967/comment/8e0d96b2_9a0054fd
PS13, Line 387: for (uint8_t socket = 0; socket < hob->PlatformData.numofIIO; ++socket) {
PlatformData. […]
There's not. CONFIG_MAX_SOCKET is a preprocessor directive, hob->PlatformData.numofIIO is a runtime variable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71967
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2a9be0222e122ae087b9cc8e1859d257e3411d6
Gerrit-Change-Number: 71967
Gerrit-PatchSet: 25
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-CC: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 27 Mar 2023 10:40:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment