Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46324 )
Change subject: soc/intel/broadwell: Revise SA lockdown sequence
......................................................................
Patch Set 4:
Patch Set 4:
(1 comment)
This would be a lot easier to review if you wouldn't change
semantics and introduce macros in the same patch. Macro
names that I also can't review because I can't find them in
docs (and the limited code in coreboot provides no hint if
the names make sense).
Good point. I'll split up the actual "revise" part from the "use macros" part
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46324
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91cd0aa61ba6bc578c892c1a5bc973bf4c28d019
Gerrit-Change-Number: 46324
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 17 Oct 2020 15:22:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment