Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35103 )
Change subject: [WIP] mb/intel/cannonlake_rvp,coffeelake_rvp: Add LPC_TPM ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
(1 comment)
I am waiting for Subrata to tell if these boards have LPC signals routed such that LPC_TPM would ever be possible. Error might be in devicetree.cb instead.
What kind of error you faced when this wasnt added in? So far we didnt see any issue without this config.
It has not been decided if CB:35086 will be merged, but I can say that the weak declarations util/sconfig autogenerates in static.c are problematic. CB:35105 CB:35106 and some more similar cases I have not fixed yet.
https://qa.coreboot.org/job/coreboot-gerrit/102175/testReport/junit/board/ch...
If there are additional requirements for LPC_TPM to work, besides the Kconfig change, I would remove pc80/tpm from devicetree.cb files instead. If you initiate commit with the required descriptor change, you get to put it back. The option to have pc80/tpm in devicetree and still have LPC_TPM=n will be solved somehow. I would probably rename 'MAINBOARD_HAS_LPC_TPM' to 'DRIVERS_PC80_TPM' and have 'LPC_TPM' to only control if device is enabled instead of using it as guard to pc80/tpm/tis.c.