[coreboot-gerrit] [L] Change in coreboot[main]: Post-build control of serial

[Simon Glass (Code Review)]

Attention is currently required from: Jérémy Compostella, Karthik Ramasubramanian, Stefan Reinauer.

Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77712?usp=email )

Change subject: Post-build control of serial
......................................................................

Patch Set 5:

(5 comments)

File Documentation/util/cbfstool/ccb.md:

https://review.coreboot.org/c/coreboot/+/77712/comment/c7f1e1ec_dc932fa9 :
PS2, Line 11: ccb-set
> I will try: […]

Done

File src/commonlib/include/commonlib/ccb.h:

https://review.coreboot.org/c/coreboot/+/77712/comment/b159aeb4_6beed98b :
PS2, Line 32: struct ccb {
            : 	uint32_t magic;
            : 	uint32_t flags;
            : };
            :
> I thought that was a vboot-specific thing? […]

Done

File src/lib/ccb.c:

https://review.coreboot.org/c/coreboot/+/77712/comment/325543cf_1937ab2b :
PS3, Line 8: struct ccb ccb_static __attribute__((section(".init"))) = {
> > `Prefer __section(".init") over __attribute__((section(".init")))` […]

Actually that one doesn't seem to work. I cannot find a header file that defines it

File util/cbfstool/cbfstool.c:

https://review.coreboot.org/c/coreboot/+/77712/comment/92f585b2_a71a647f :
PS4, Line 2140: 		        "Get a value from the Coreboot Control Block\n"
> > `code indent should use tabs where possible` […]

Done

https://review.coreboot.org/c/coreboot/+/77712/comment/ced8c77c_0eedca58 :
PS4, Line 2142: 		        "Set a value in the Coreboot Control Block\n"
> > `code indent should use tabs where possible` […]

Done