[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso/sb: Gate FCH AL2AHB clocks

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42829 )

Change subject: soc/amd/picasso/sb: Gate FCH AL2AHB clocks
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42829/6/src/soc/amd/picasso/include... 
File src/soc/amd/picasso/include/soc/iomap.h:

https://review.coreboot.org/c/coreboot/+/42829/6/src/soc/amd/picasso/include... 
PS6, Line 19: #define   AL2AHB_CLK_GATE_EN		BIT(1)
using BIT() needs to have types.h included in this file. I'd prefer (1 << 1) instead of BIT(1) though which is more in line with the coreboot code base