Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36071 )
Change subject: superio: IT8587E (WIP)
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36071/3/src/superio/ite/it8587e/it8...
File src/superio/ite/it8587e/it8587e.h:
https://review.coreboot.org/c/coreboot/+/36071/3/src/superio/ite/it8587e/it8...
PS3, Line 6: SP1
UART1
https://review.coreboot.org/c/coreboot/+/36071/3/src/superio/ite/it8587e/it8...
PS3, Line 7: SP2
UART2
https://review.coreboot.org/c/coreboot/+/36071/3/src/superio/ite/it8587e/it8...
PS3, Line 10: #define IT8587E_KBCK 0x06 /* PS/2 keyboard */
Add ..
#define IT8587E_CIR 0x0a /* Consumer IR */
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36071
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e541daa2b3d48a4f5a0e7b7fa88a2c2f8a1b0c5
Gerrit-Change-Number: 36071
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Dec 2020 23:22:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment