Youness Alaoui (snifikino@gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18514
-gerrit
commit ce388f059898697a1b747228289c55e52193f85c Author: Youness Alaoui kakaroto@kakaroto.homelinux.net Date: Mon Feb 27 12:03:39 2017 -0500
intel/broadwell: Use the correct SATA port config for setting IOBP register
Fix a typo that was introduce in change #18408. https://review.coreboot.org/#/c/18408/ Setting one of the SATA port 3 IOBP setting was using the value from the port 2 register. On the purism/librem13 (on which SATA port 3 is tested), this change doesn't seem to affect anything, as that typo wasn't exhibiting any visible problems anyways.
Change-Id: I3948def5c0588791009c4b24cbc061552d9d1d48 Signed-off-by: Youness Alaoui youness.alaoui@puri.sm --- src/soc/intel/broadwell/sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/soc/intel/broadwell/sata.c b/src/soc/intel/broadwell/sata.c index 1f2e690..7b9bd0c 100644 --- a/src/soc/intel/broadwell/sata.c +++ b/src/soc/intel/broadwell/sata.c @@ -161,7 +161,7 @@ static void sata_init(struct device *dev) pch_iobp_update(SATA_IOBP_SP3_SECRT88, ~(SATA_SECRT88_VADJ_MASK << SATA_SECRT88_VADJ_SHIFT), - (config->sata_port2_gen3_tx & + (config->sata_port3_gen3_tx & SATA_SECRT88_VADJ_MASK) << SATA_SECRT88_VADJ_SHIFT);