Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31664 )
Change subject: cpu/intel/model_1067x: Implement microcode loading ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31664/1/src/cpu/intel/model_1067x/mp_init.c File src/cpu/intel/model_1067x/mp_init.c:
https://review.coreboot.org/#/c/31664/1/src/cpu/intel/model_1067x/mp_init.c@... PS1, Line 116: microcode_patch = intel_microcode_find(); : intel_microcode_load_unlocked(microcode_patch);
can also be done in pre_mp_init. I don't feel strongly about either one.
Oh, right. I intuitively put it here, because I knew exactly that `microcode_patch` will be initialized early enough. pre_mp_init() guarantees that too (just read the documentation in the header file now).
Hmmm, or maybe split them up? Keep the initialization here as a prerequisite. Move the loading into pre_mp_init()?