Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43255 )
Change subject: arch/arm/include/smp/spinlock.h: Drop dead code
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43255/1/src/arch/arm/include/smp/sp...
File src/arch/arm/include/smp/spinlock.h:
https://review.coreboot.org/c/coreboot/+/43255/1/src/arch/arm/include/smp/sp...
PS1, Line 7: #error "implement this for ARM"
I'd be okay with just removing the whole file, too.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43255
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23f9aa969febe58dd3842e6a7cc75a6777b90b17
Gerrit-Change-Number: 43255
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 07 Jul 2020 23:32:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment