Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40391 )
Change subject: nb/intel/i440bx: Clean up register_values table ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40391/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40391/1//COMMIT_MSG@9 PS1, Line 9: The table of initial i440BX register values has a bitmask that allows preserving
The lines are a tad bit too long, mind reflowing this? […]
Done
https://review.coreboot.org/c/coreboot/+/40391/1//COMMIT_MSG@11 PS1, Line 11: and probably will never be used. Drop it to save some bytes.
37 bytes off the table itself. […]
Ack
https://review.coreboot.org/c/coreboot/+/40391/1/src/northbridge/intel/i440b... File src/northbridge/intel/i440bx/raminit.c:
https://review.coreboot.org/c/coreboot/+/40391/1/src/northbridge/intel/i440b... PS1, Line 346: PGPOL
I would prefer that comment directly below the comment for PGPOL above.
Done
https://review.coreboot.org/c/coreboot/+/40391/1/src/northbridge/intel/i440b... PS1, Line 664: for (i = 0; i < max; i += 2) {
braces {} are not necessary for single statement blocks
Done