Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35012 )
Change subject: samsung/exynos,qualcomm/ipq: Avoid conflicting DRAM_START
......................................................................
Patch Set 2:
Is this just because you include stddef.h from memlayout.h? I don't think we should do that, I think we should rather move those ARCH_STAGE_xxx definitions from memlayout.h into rules.h. memlayout.h was only ever meant to be the header included directly by memlayout.ld files and defining the memlayout "language", not a general collection of program state macros (that should be rules.h).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35012
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c41052542b215de8af3be858ca7a229e4206ecf
Gerrit-Change-Number: 35012
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 20 Aug 2019 18:23:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment