Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42328 )
Change subject: mb/google/zork: Disable UART 2 and 3
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42328/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42328/1/src/mainboard/google/zork/v...
PS1, Line 189:
If I set something off here, and the override tree sets it to on, is the final value on? I want to s […]
Yes, if you set device to `off` here and `on` in overridetree.cb then the final result would be `on` for the variants using the overrridetree.cb and `off` for others.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42328
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fadeba779b66ec2fb13951b9487118ef0737a94
Gerrit-Change-Number: 42328
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jun 2020 16:48:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment