Attention is currently required from: Sean Rhodes, Andy Pont. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52797 )
Change subject: ec: Add Star Labs ITE 8987E support ......................................................................
Patch Set 12: Code-Review+1
(4 comments)
File src/ec/starlabs/it8987/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/52797/comment/7f6aaf0e_d35fd7f9 PS12, Line 77: // Support DPTF feature If you want to add DPTF support, it should be pretty easy, using the `drivers/intel/dptf` chip driver (see https://doc.coreboot.org/drivers/dptf.html)
https://review.coreboot.org/c/coreboot/+/52797/comment/a732974b_f748ea9c PS12, Line 373: : // Method(_Q45) // SMM Mode - Not used in coreboot : // { : // SMB2 = 0xC1 : // } remove?
File src/ec/starlabs/it8987/acpi/hid.asl:
PS12: just in general, why keep all of these commented-out lines?
https://review.coreboot.org/c/coreboot/+/52797/comment/b72728ff_e993d9dd PS12, Line 16: // If (((OSYS >= 0x07DD) && (HEFE == One))) remove?