Attention is currently required from: Paul Menzel, Angel Pons, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47223 )
Change subject: nb/intel/haswell/pcie.c: Add missing pre-ASPM init
......................................................................
Patch Set 9: Code-Review+2
(2 comments)
Patchset:
PS9:
I forgot two times during review that it's about PEG (i.e. not
the PCH RPs). Defaults makes sense for PEG! ^^
File src/northbridge/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/47223/comment/32072c08_d14c213b
PS9, Line 23: #define PEG_CAP 0xa2
I just realized, most of these are PCIe standard anyway, just
the base offset is implementation specific. Here, everything
is +0xa0. e.g.
PEG_CAP == 0xa0 + PCI_EXP_FLAGS,
PEG_DCAP == 0xa0 + PCI_EXP_DEVCAP
etc.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47223
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dcdd4ca431c2ae1e62f2719c376d8bdef3054bd
Gerrit-Change-Number: 47223
Gerrit-PatchSet: 9
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 07 Mar 2021 20:01:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment