Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87101?usp=email )
Change subject: mb/starlabs/starbook/*: Tidy GPIO comments for eSPI ......................................................................
mb/starlabs/starbook/*: Tidy GPIO comments for eSPI
This is a non-functional change, and only makes the GPIOs easier to read.
Change-Id: Id6a30adbc434c975cda1cdcffd164650910e1da3 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/87101 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c M src/mainboard/starlabs/starbook/variants/adl/gpio.c M src/mainboard/starlabs/starbook/variants/mtl/gpio.c M src/mainboard/starlabs/starbook/variants/rpl/gpio.c M src/mainboard/starlabs/starbook/variants/tgl/gpio.c M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c 7 files changed, 54 insertions(+), 55 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index 3814deb..dbbd7da 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -25,6 +25,15 @@ PAD_NC(GPD5, NONE), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */
+ /* eSPI */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A0, UP_20K, DEEP, NF1), /* eSPI IO 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A1, UP_20K, DEEP, NF1), /* eSPI IO 1 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A2, UP_20K, DEEP, NF1), /* eSPI IO 2 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A3, UP_20K, DEEP, NF1), /* eSPI IO 3 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A4, UP_20K, DEEP, NF1), /* eSPI CS 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -38,11 +47,6 @@ /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE),
- /* A0: ESPI IO 0 */ - /* A1: ESPI IO 1 */ - /* A2: ESPI IO 2 */ - /* A3: ESPI IO 3 */ - /* A4: ESPI CS 0 */ /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), /* A6: Not Connected */ @@ -51,8 +55,6 @@ PAD_NC(GPP_A7, NONE), /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A9: ESPI Clock */ - /* A10: ESPI Reset */ /* A11: Webcam Camera Reset */ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index 619b315..0e6816d 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -25,6 +25,15 @@ PAD_NC(GPD5, NONE), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */
+ /* eSPI */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A0, UP_20K, DEEP, NF1), /* eSPI IO 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A1, UP_20K, DEEP, NF1), /* eSPI IO 1 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A2, UP_20K, DEEP, NF1), /* eSPI IO 2 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A3, UP_20K, DEEP, NF1), /* eSPI IO 3 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A4, UP_20K, DEEP, NF1), /* eSPI CS 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -38,11 +47,6 @@ /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE),
- /* A0: ESPI IO 0 */ - /* A1: ESPI IO 1 */ - /* A2: ESPI IO 2 */ - /* A3: ESPI IO 3 */ - /* A4: ESPI CS 0 */ /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), /* A6: Not Connected */ @@ -51,8 +55,6 @@ PAD_NC(GPP_A7, NONE), /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A9: ESPI Clock */ - /* A10: ESPI Reset */ /* A11: Not Connected */ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index c3b4c6d..c5e3c26 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -30,6 +30,15 @@ PAD_CFG_NF(GPP_V05, NONE, DEEP, NF1), /* Sleep S4 */ PAD_CFG_NF(GPP_V08, NONE, DEEP, NF1), /* Bluetooth Suspend */
+ /* eSPI */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A00, UP_20K, DEEP, NF1), /* eSPI IO 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A01, UP_20K, DEEP, NF1), /* eSPI IO 1 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A02, UP_20K, DEEP, NF1), /* eSPI IO 2 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A03, UP_20K, DEEP, NF1), /* eSPI IO 3 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A04, UP_20K, DEEP, NF1), /* eSPI CS 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A05, UP_20K, DEEP, NF1), /* eSPI Clk */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A06, NONE, DEEP, NF1), /* eSPI Reset */ + /* V02: PCIE_WAKE_LAN */ PAD_NC(GPP_V02, NONE), /* V06: GPD_6_SLP_A_N */ @@ -129,20 +138,6 @@ * Start: GPP_A00 * End: GPP_A23 */ - /* A00: ESPI_IO0_EC_R */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A00, UP_20K, DEEP, NF1), - /* A01: ESPI_IO1_EC_R */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A01, UP_20K, DEEP, NF1), - /* A02: ESPI_IO2_EC_R */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A02, UP_20K, DEEP, NF1), - /* A03: ESPI_IO3_EC_R */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A03, UP_20K, DEEP, NF1), - /* A04: ESPI_CS0_N */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A04, UP_20K, DEEP, NF1), - /* A05: ESPI_CLK_EC_R */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A05, UP_20K, DEEP, NF1), - /* A06: ESPI_RESET_N */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A06, NONE, DEEP, NF1), /* A07: */ PAD_NC(GPP_A07, NONE), /* A08: */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 1aeb866..817230a 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -25,6 +25,15 @@ PAD_NC(GPD5, NONE), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */
+ /* eSPI */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A0, UP_20K, DEEP, NF1), /* eSPI IO 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A1, UP_20K, DEEP, NF1), /* eSPI IO 1 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A2, UP_20K, DEEP, NF1), /* eSPI IO 2 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A3, UP_20K, DEEP, NF1), /* eSPI IO 3 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A4, UP_20K, DEEP, NF1), /* eSPI CS 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -39,11 +48,6 @@ /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE),
- /* A0: ESPI IO 0 */ - /* A1: ESPI IO 1 */ - /* A2: ESPI IO 2 */ - /* A3: ESPI IO 3 */ - /* A4: ESPI CS 0 */ /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), /* A6: Not Connected */ @@ -52,8 +56,6 @@ PAD_NC(GPP_A7, NONE), /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A9: ESPI Clock */ - /* A10: ESPI Reset */ /* A11: Not Connected */ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index 08e2563..3c19970 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -38,12 +38,6 @@ /* GPD11: PM_LANPHY_EN */ PAD_CFG_NF(GPD11, NONE, DEEP, NF1),
- /* A0: ESPI_IO_0 */ - /* A1: ESPI_IO_1 */ - /* A2: ESPI_IO_2 */ - /* A3: ESPI_IO_3 */ - /* A4: ESPI_CS_L */ - /* A5: ESPI_CLK */ /* A6: Not Connected(TP764) */ /* A7: WLAN_PCM_CLK */ PAD_NC(GPP_A7, NONE), diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index 3ffa198..4f46467 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -35,6 +35,15 @@ PAD_NC(GPD5, NONE), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */
+ /* eSPI */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A0, UP_20K, DEEP, NF1), /* eSPI IO 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A1, UP_20K, DEEP, NF1), /* eSPI IO 1 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A2, UP_20K, DEEP, NF1), /* eSPI IO 2 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A3, UP_20K, DEEP, NF1), /* eSPI IO 3 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A4, UP_20K, DEEP, NF1), /* eSPI CS 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -48,11 +57,6 @@ /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE),
- /* A0: ESPI IO 0 */ - /* A1: ESPI IO 1 */ - /* A2: ESPI IO 2 */ - /* A3: ESPI IO 3 */ - /* A4: ESPI CS 0 */ /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), /* A6: Not Connected */ @@ -61,8 +65,6 @@ PAD_NC(GPP_A7, NONE), /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A9: ESPI Clock */ - /* A10: ESPI Reset */ /* A11: Not Connected */ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index 4e96453..64e7b83 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -25,6 +25,15 @@ PAD_NC(GPD5, NONE), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */
+ /* eSPI */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A0, UP_20K, DEEP, NF1), /* eSPI IO 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A1, UP_20K, DEEP, NF1), /* eSPI IO 1 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A2, UP_20K, DEEP, NF1), /* eSPI IO 2 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A3, UP_20K, DEEP, NF1), /* eSPI IO 3 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A4, UP_20K, DEEP, NF1), /* eSPI CS 0 */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */ + // PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -38,11 +47,6 @@ /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE),
- /* A0: ESPI IO 0 */ - /* A1: ESPI IO 1 */ - /* A2: ESPI IO 2 */ - /* A3: ESPI IO 3 */ - /* A4: ESPI CS 0 */ /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), /* A6: Not Connected */ @@ -51,8 +55,6 @@ PAD_NC(GPP_A7, NONE), /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A9: ESPI Clock */ - /* A10: ESPI Reset */ /* A11: Webcam Camera Reset */ PAD_NC(GPP_A11, NONE), /* A12: Not Connected */