Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: cpucp loading changes ......................................................................
Patch Set 35:
(42 comments)
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/679fdc99_dc653e48 PS35, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/c98cece0_13e75b73 PS35, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/e7436456_fd142c77 PS35, Line 16: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/fd5d9775_af4e100d PS35, Line 16: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/09f2d068_692a784b PS35, Line 18: /* allow NS access to EPSS memory*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/d3c775db_1741315f PS35, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/d020b2c0_af31d750 PS35, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/c08f8e7a_3383291b PS35, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/46210e20_0e69704a PS35, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/236429e3_9678e3a6 PS35, Line 22: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/4d482615_bcb7a050 PS35, Line 22: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/b54dab2b_13ee6278 PS35, Line 24: /* Enable subsystem clock. Required for CPUCP PDMEM access*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/fbef7fdd_ed0c2046 PS35, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/bbf44ab1_7461623e PS35, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/e581e07c_3e1d1a55 PS35, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/95a8ba50_f312b015 PS35, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/2f3c3550_da0ad769 PS35, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/55382636_5d44e3ed PS35, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/abcd3fa9_031b1e32 PS35, Line 32: bool cpucp_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/3ffd6096_a78d557d PS35, Line 32: bool cpucp_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/7aa97012_ab78badf PS35, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/515b3dee_05f65845 PS35, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/5bfe7184_eb642c4d PS35, Line 35: struct prog cpucp_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/d3b9366a_5d49f65b PS35, Line 35: struct prog cpucp_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/6cb02e31_48503ab7 PS35, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/0fc6d9b2_32398c0a PS35, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/f0e71422_7eb6e60c PS35, Line 38: cpucp_prepare(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/b33d2f47_3a1fdc02 PS35, Line 38: cpucp_prepare(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/eb18d427_6892affc PS35, Line 40: if (prog_locate(&cpucp_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/2897849b_7d3d9092 PS35, Line 40: if (prog_locate(&cpucp_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/4bee438c_1812b991 PS35, Line 41: die("SOC imagpe: CPUCP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/65fc660c_f59f7214 PS35, Line 41: die("SOC imagpe: CPUCP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/db9c6ef3_3d4b82e3 PS35, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/920d7e6e_fe8e9fdb PS35, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/a6a9e977_619c7a11 PS35, Line 44: if (!cpucp_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/52be1146_29446134 PS35, Line 44: if (!cpucp_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/d4511b41_6ad1162b PS35, Line 45: die("SOC image: CPUCP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/978a96b8_7d40d872 PS35, Line 45: die("SOC image: CPUCP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/bd679f72_e3975670 PS35, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/08a5ce1d_5a939368 PS35, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/9028be1e_544212ca PS35, Line 20: REGION_SIZE(dram_cpucp) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119122): https://review.coreboot.org/c/coreboot/+/49768/comment/4997f02d_9bc0c6a9 PS35, Line 20: REGION_SIZE(dram_cpucp) / KiB); please, no spaces at the start of a line