Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35623 )
Change subject: TEST-ONLY: Add anx7625 driver
......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762...
File src/drivers/analogix/anx7625/anx7625.c:
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762...
PS3, Line 150: BIOS_INFO
BIOS_ERROR?
Done
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762...
PS3, Line 155: BIOS_INFO
BIOS_DEBUG ?
Done
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762...
PS3, Line 182: *a
change these params to _a, _b […]
Done
https://review.coreboot.org/c/coreboot/+/35623/3/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/35623/3/src/mainboard/google/kukui/...
PS3, Line 45: DRIVER_ANALOGIX_ANX7625
Please include ANX7625 for Juniper and don't change jacuzzi.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35623
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02ef29798b0257632e0750f09a4390b3d0226367
Gerrit-Change-Number: 35623
Gerrit-PatchSet: 10
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Ben Ho
Ben.Ho@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-CC: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-CC: Ting Shen
phoenixshen@google.com
Gerrit-Comment-Date: Tue, 10 Dec 2019 10:18:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment
