Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34598 )
Change subject: lib/bootsplash: Log bootsplash dimensions and framebuffer dimensions
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34598/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34598/4//COMMIT_MSG@9
PS4, Line 9: The bootsplash.jpg needs to match the framebuffer resolution.
decode_jpeg will return an error and log. […]
Ok, then I still think it might be a good idea to print a log message about the size only if it does match, but then make it clear in the log message that there is a mismatch.
Your choice though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34598
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a06d53c0134b99d3e9e6d3eda9fa30fca9ef7d
Gerrit-Change-Number: 34598
Gerrit-PatchSet: 4
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 17 Aug 2019 11:33:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mimoja
coreboot@mimoja.de
Comment-In-Reply-To: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-MessageType: comment