Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37874 )
Change subject: soc/intel/cannonlake: Add VR config for CML ......................................................................
Patch Set 5:
(2 comments)
Patch Set 4:
(1 comment)
How to trigger the build bot to rebuild again?
https://review.coreboot.org/c/coreboot/+/37874/4/src/soc/intel/cannonlake/ch... File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/37874/4/src/soc/intel/cannonlake/ch... PS4, Line 221: /* CPU PL2/4 Config : * Performance: Maximum PLs for maximum performance. : * Baseline: Baseline PLs for balanced performance at lower power. */
pls change the code comment format. […]
Done
https://review.coreboot.org/c/coreboot/+/37874/4/src/soc/intel/cannonlake/vr... File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/37874/4/src/soc/intel/cannonlake/vr... PS4, Line 151: () values when PL2_4_Config is baseline.
The above values in () are for baseline.
Done