Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37229 )
Change subject: hatch: Create stryke variant
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37229/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/stryke/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/37229/2/src/mainboard/google/hatch/...
PS2, Line 20: /* Copied from baseboard and may need to change for the new variant. */
Ack. Since I am not a Google employee nor a partner, I don't have access to the issue tracker. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37229
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea6f8a1c6c24a1e3545c364551cb623debdc4a1a
Gerrit-Change-Number: 37229
Gerrit-PatchSet: 3
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Jasper Lee
jasper_lee@compal.com
Gerrit-CC: JoeJ Chang
joej_chang@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Dec 2019 09:18:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-MessageType: comment