Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34872 )
Change subject: google/kukui: Load and run dram init blob
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34872/1/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/34872/1/src/mainboard/google/kukui/...
PS1, Line 44: memset(_dram_init_code + blob_size, 0, region_size - blob_size);
Guys, why are we inventing our own loading conventions? Please provide the DRAM blob as an ELF, not […]
I thought there was no pure ELF (non-stage, non-payload) support in Coreboot? But maybe I missed some APIs.
For stage - can we call a stage that was not built from Coreboot source (and layout), and return back to where it was called?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad05a77e6353f37cd5ea897203d528762f44176e
Gerrit-Change-Number: 34872
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Aug 2019 04:14:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Tristan Hsieh
tristan.shieh@mediatek.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment