Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40674 )
Change subject: arch/x86/acpi_device: Add a helper function to write PCI device ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40674/4/src/arch/x86/include/arch/a... File src/arch/x86/include/arch/acpi_device.h:
https://review.coreboot.org/c/coreboot/+/40674/4/src/arch/x86/include/arch/a... PS4, Line 507: Device that is added to SSDT cannot be accessed from DSDT. So, if there are any : * references to this PCI device required from static asl files, do not use this function and : * instead add the device to DSDT as well Can't an External reference be placed there and CondRefOf used to safely access it?