[coreboot-gerrit] Change in ...coreboot[master]: src/mb/sifive/hifive-unleashed: replace fdt in maskrom

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31047 )

Change subject: src/mb/sifive/hifive-unleashed: replace fdt in maskrom
......................................................................

Patch Set 13:

(2 comments)

https://review.coreboot.org/#/c/31047/13/src/mainboard/sifive/hifive-unleash... 
File src/mainboard/sifive/hifive-unleashed/fdt.c:

https://review.coreboot.org/#/c/31047/13/src/mainboard/sifive/hifive-unleash... 
PS13, Line 19: 
why doesn't you use existing code in lib/device_tree.c ?

https://review.coreboot.org/#/c/31047/13/src/mainboard/sifive/hifive-unleash... 
File src/mainboard/sifive/hifive-unleashed/romstage.c:

https://review.coreboot.org/#/c/31047/13/src/mainboard/sifive/hifive-unleash... 
PS13, Line 31: static void update_dtb(void)
why is it done in romstage ?