Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48657 )
Change subject: soc/intel/xeon_sp: Move DMICTL lock
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48657/1/src/soc/intel/xeon_sp/cpx/c...
File src/soc/intel/xeon_sp/cpx/chip.c:
https://review.coreboot.org/c/coreboot/+/48657/1/src/soc/intel/xeon_sp/cpx/c...
PS1, Line 82: pch_lock_dmictl();
Could this be moved to chip_final() instead?
Needs to happen before LockConfig iirc.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48657
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8ef7bab36bfd4b62988768753d10b4d7b7d567f
Gerrit-Change-Number: 48657
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Dec 2020 13:14:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment