14 Sep
2020
14 Sep
'20
11:41 p.m.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45371 )
Change subject: mb/51nb/x210/gpio: Remove comments that contain pad functions ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45371/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45371/1//COMMIT_MSG@9 PS1, Line 9: Remove these comments, because it does not contain useful information : that helps to understand the circuit, which we do not have. I'm confused, how does removing the comments make understanding the GPIO config more clear?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45371
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a994a6f27d830bd05819043336d12c2ecef2f48
Gerrit-Change-Number: 45371
Gerrit-PatchSet: 1
Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-Comment-Date: Mon, 14 Sep 2020 21:41:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment