Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35023 )
Change subject: libpayload/usb: add USB 3.1 GEN2 support ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35023/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/usb.c:
https://review.coreboot.org/c/coreboot/+/35023/2/payloads/libpayload/drivers... PS2, Line 701: int is_usb_speed_ss(usb_speed speed) : { : if (speed == SUPER_SPEED || speed == SUPER_SPEED_PLUS) : return 1; : return 0; : }
I want this be a little flexible. […]
Sure, then you can change it to: return (speed == SUPER_SPEED || speed == SUPER_SPEED_PLUS || speed == SUPER_SPEED_MEGA) or whatever it's called next :)
https://review.coreboot.org/c/coreboot/+/35023/2/payloads/libpayload/include... File payloads/libpayload/include/usb/usb.h:
https://review.coreboot.org/c/coreboot/+/35023/2/payloads/libpayload/include... PS2, Line 297: int
I tried but it needs _Bool, and true and false bot not define. […]
It looks like libpayload has a <stdbool.h> that should reference 'bool', 'true', and 'false'.