Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35345 )
Change subject: mb/google/hatch: override smbios manufacturer name from CBI
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35345/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35345/1/src/mainboard/google/hatch/...
PS1, Line 56: smbios_mainboard_manufacturer
Some day I think it might make sense to move this to ec/google/chromeec/. […]
OK. thanks
https://review.coreboot.org/c/coreboot/+/35345/1/src/mainboard/google/hatch/...
PS1, Line 66: BIOS_ERR
I don't think this should be BIOS_ERR. […]
Yes, it's not an error. I will change to use BIOS_INFO.
Thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9be85fbc47031d049b5bd51cfaf6232cab24e9fe
Gerrit-Change-Number: 35345
Gerrit-PatchSet: 1
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 11 Sep 2019 06:50:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment