build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48253 )
Change subject: drivers/intel/usb4: Add Mux Ack driver ......................................................................
Patch Set 1:
(12 comments)
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... File src/drivers/intel/usb4/mux_ack/Kconfig:
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... PS1, Line 5: The mux ack driver is required when syncronization is needed 'syncronization' may be misspelled - perhaps 'synchronization'?
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... File src/drivers/intel/usb4/mux_ack/ack.c:
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... PS1, Line 13: #define INTEL_USB4_MUX_ACK_DSM_UUID "5e7fb958-b2c5-49dc-90b9-f95b1275e824" please, no space before tabs
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... PS1, Line 49: struct acpi_gpio *ack_gpio = arg; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... PS1, Line 62: struct acpi_gpio *ack_gpio = arg; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... PS1, Line 102: const struct drivers_intel_usb4_mux_ack_config *config = dev->chip_info; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... PS1, Line 103: const char *scope = acpi_device_scope(dev); Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... PS1, Line 105: if (!scope || !config) Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... PS1, Line 108: if (!config->ack_gpio.pin_count) { Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... PS1, Line 111: } Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... File src/drivers/intel/usb4/mux_ack/chip.h:
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... PS1, Line 9: /* GPIO used to tell EC that a mux mode request has been completed. */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... PS1, Line 10: struct acpi_gpio ack_gpio; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/48253/1/src/drivers/intel/usb4/mux_... PS1, Line 10: struct acpi_gpio ack_gpio; please, no spaces at the start of a line