Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32432 )
Change subject: soc/intel/cnl: Enable VT-d
......................................................................
Patch Set 3:
Patch Set 3:
(1 comment)
Enable by default will be okay? Or we can still disable that by default and leave mainboard to decide that's enabled or disabled?
I would prefer to enable it and not to have an option
at all until somebody asks for an option to disable it.
Or does anybody already want to disable it?
IMHO, the `VtdDisable` in `chip.h` should be (re)moved
anyway: It's not a mainboard question but a question of
the coreboot build and, thus, belongs into Kconfig.
Not I am aware of, just want to be more conservative here. But if no one is against it, I am okay to cast my vote.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32432
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d20932e417b9d324edd98c8f2195dc228d2e092
Gerrit-Change-Number: 32432
Gerrit-PatchSet: 3
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 26 Apr 2019 18:59:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment