Patrick Georgi (pgeorgi@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9098
-gerrit
commit 7e6e6db7ef26b1bd0eda15ec2a5aa774fd2e65e5 Author: Aaron Durbin adurbin@chromium.org Date: Fri Sep 19 16:01:03 2014 -0500
arm64: remove EL and mode from secmon_params
Since PSCI dynamically determines which EL to transition to based on SCR_EL3 there's no need to provide that information.
BUG=chrome-os-partner:30785 BRANCH=None TEST=Built and booted into kernel with MP.
Change-Id: Ia59bc8116ec4ae9bde2e6cad1861f76c14f7d495 Signed-off-by: Patrick Georgi pgeorgi@chromium.org Original-Commit-Id: 8bc5f7c8a114568ede98478c2fbea2f8b7d97f0c Original-Change-Id: I8783b6315dca01464e14c9d2b20d009cf0beeb67 Original-Signed-off-by: Aaron Durbin adurbin@chromium.org Original-Reviewed-on: https://chromium-review.googlesource.com/218924 Original-Reviewed-by: Furquan Shaikh furquan@chromium.org --- src/arch/arm64/armv8/secmon_loader.c | 4 ---- src/arch/arm64/include/armv8/arch/secmon.h | 2 -- 2 files changed, 6 deletions(-)
diff --git a/src/arch/arm64/armv8/secmon_loader.c b/src/arch/arm64/armv8/secmon_loader.c index e571b51..0098228 100644 --- a/src/arch/arm64/armv8/secmon_loader.c +++ b/src/arch/arm64/armv8/secmon_loader.c @@ -139,10 +139,6 @@ void secmon_run(void (*entry)(void *), void *cb_tables)
runit.bsp_params.entry = entry; runit.bsp_params.arg = cb_tables; - runit.bsp_params.elx_el = EL2; - runit.bsp_params.elx_mode = SPSR_USE_L; - runit.secondary_params.elx_el = EL2; - runit.secondary_params.elx_mode = SPSR_USE_L;
spin_attrs = spintable_get_attributes();
diff --git a/src/arch/arm64/include/armv8/arch/secmon.h b/src/arch/arm64/include/armv8/arch/secmon.h index 5245e31..12dd8c4 100644 --- a/src/arch/arm64/include/armv8/arch/secmon.h +++ b/src/arch/arm64/include/armv8/arch/secmon.h @@ -27,8 +27,6 @@ struct secmon_params { void (*entry)(void *); void *arg; - uint8_t elx_el; - uint8_t elx_mode; };
void secmon_run(void (*entry)(void *), void *arg);